Pick the dynamic filter from #353 #364

liuchengxu · 2020-03-30T10:31:32Z

I have cherry-picked the dynamic filter code from #353, and refacotor it a bit. There are still some details to deal with, but mostly works great in Vim.

[fixed] But I notice something weired in the top results returned during the dynamic update, see 00:30~00:43 in this gif https://asciinema.org/a/FT3magg2dk6VHIVg04PYgfIpw , the top first item looks right and is seemingly stable, while the other top N items looks far from the top first one. In the end, the results looks right suddently. I'm a little confused. @ImmemorConsultrixContrarie

ImmemorConsultrixContrarie · 2020-03-30T12:00:13Z

But I notice something weired in the top results returned during the dynamic update, see 00:30~00:43 in this gif https://asciinema.org/a/FT3magg2dk6VHIVg04PYgfIpw , the top first item looks right and is seemingly stable, while the other top N items looks far from the top first one. In the end, the results looks right suddently. I'm a little confused.

Looks like a bug in sorting algo for temporary results. I could have done this sort wrong. Also some logic bugs could have crawled into this function or this macro.

ImmemorConsultrixContrarie · 2020-03-30T12:09:51Z

Yeah, it's there.
The chain should be like .iter().enumerate().rev(), but .rev() goes before the enumerate.

@liuchengxu

liuchengxu · 2020-03-30T12:24:54Z

Yeah, it's there.
The chain should be like .iter().enumerate().rev(), but .rev() goes before the enumerate.

Yes, that's the culprit 👍, now it looks all right.

Ref #364 (comment)

autoload/clap/filter/async/dyn.vim

autoload/clap/provider/grep.vim

…pick-dyn-filter

source_type are different

…pick-dyn-filter

The forerunnner job should also be moved into maple.

autoload/clap/state.vim

liuchengxu and others added 13 commits March 29, 2020 18:04

Pick dyn filter code

1ba2b2c

Replaced f64 scoring with i32.

4a15231

Make it compile

a4bb575

Intergate with vim initially

12a8d47

Change ITEMS_TO_SHOW to 100

6782304

Split filter sync/async

595daba

Move to filter/async/dyn.vim

1906bee

Split out print_top_items()

e6c28fc

.

3393700

Split out select_top_items_to_show()

7d40877

Extract find_bast_score_idx() and try_notify_top_results()

894e9a5

Fix vint

7b7a2e1

Pass enable_icon to try_notify_top_results()

d7bdfea

liuchengxu added 10 commits March 30, 2020 20:25

Fix sorting glitch in top scores

f7bb807

Ref #364 (comment)

Pass --enable-icon in vimscript

f3b0300

Update CHANGELOG

0522228

Support neovim too

29b88b5

Process truncated_map in vim

7970cc1

Introduce Source::Exec

aece025

Commit state.vim

b849ba1

Fix vint

a8fdd39

Split out clap#state#handle_message()

c6f5ba6

Pass cmd into clap#filter#async#start(cmd)

e1a2f2a

liuchengxu mentioned this pull request Mar 31, 2020

An example of dynamic results provider, using stdout #353

Closed

Try using dyn filter on grep provider

742732a

github-actions bot reviewed Mar 31, 2020

View reviewed changes

autoload/clap/filter/async/dyn.vim Outdated Show resolved Hide resolved

autoload/clap/provider/grep.vim Outdated Show resolved Hide resolved

autoload/clap/provider/grep.vim Outdated Show resolved Hide resolved

.

4aea5c7

liuchengxu added 3 commits April 2, 2020 13:32

Nits

1be30c8

Use systemlist()

0fb5979

Merge branch 'master' of https://github.com/liuchengxu/vim-clap into …

6b14021

…pick-dyn-filter

liuchengxu mentioned this pull request Apr 2, 2020

Performance is dramatically bad comparing to fzf.vim #343

Closed

liuchengxu added 11 commits April 2, 2020 20:43

Merge branch 'master' of https://github.com/liuchengxu/vim-clap into …

cde7b0e

…pick-dyn-filter

Only when using maple

d436afe

Split out job/stdio.vim

6cf6197

Clean up dyn.vim

820ac95

Remove rpc.vim

5d8f729

Add job/stdio.vim

c0cc692

Fix switching between files and history provider

9938aa1

source_type are different

Merge branch 'master' of https://github.com/liuchengxu/vim-clap into …

c0fae09

…pick-dyn-filter

Check if has g:__clap_forerunner_tempfile

a72ee23

The forerunnner job should also be moved into maple.

Clear g:__clap_provider_cwd on exit

c2e1d11

Add clap#state#refresh_matches_count_on_forerunner_done()

c715aa4

github-actions bot reviewed Apr 3, 2020

View reviewed changes

autoload/clap/state.vim Outdated Show resolved Hide resolved

liuchengxu added 5 commits April 3, 2020 15:09

Fix vint

0c940a7

.

5a57f0d

Make maple.vim run filter --sync

f8a3184

.

be5b05b

.

266ab2a

liuchengxu mentioned this pull request Apr 3, 2020

Support dynamic update in maple for grep/files provider #302

Closed

2 tasks

Reset g:__clap_provider_cwd on start

adbbd28

liuchengxu force-pushed the pick-dyn-filter branch from c4ae178 to adbbd28 Compare April 3, 2020 14:55

liuchengxu added 4 commits April 3, 2020 22:56

.

ac771aa

Put s:clear_state() before setting provider source_type

8525cd0

Extract clap#state#clear_pre() and clap#state#clear_post()

b47fbb1

.

bd77cba

liuchengxu merged commit c1cdfa7 into master Apr 4, 2020

delete-merged-branch bot deleted the pick-dyn-filter branch April 4, 2020 04:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pick the dynamic filter from #353 #364

Pick the dynamic filter from #353 #364

liuchengxu commented Mar 30, 2020 •

edited

Loading

ImmemorConsultrixContrarie commented Mar 30, 2020

ImmemorConsultrixContrarie commented Mar 30, 2020 •

edited

Loading

liuchengxu commented Mar 30, 2020

Pick the dynamic filter from #353 #364

Pick the dynamic filter from #353 #364

Conversation

liuchengxu commented Mar 30, 2020 • edited Loading

ImmemorConsultrixContrarie commented Mar 30, 2020

ImmemorConsultrixContrarie commented Mar 30, 2020 • edited Loading

liuchengxu commented Mar 30, 2020

liuchengxu commented Mar 30, 2020 •

edited

Loading

ImmemorConsultrixContrarie commented Mar 30, 2020 •

edited

Loading